Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aider added updating and not using url #194

Merged
merged 4 commits into from
Nov 26, 2024
Merged

Aider added updating and not using url #194

merged 4 commits into from
Nov 26, 2024

Conversation

nang-dev
Copy link

@nang-dev nang-dev commented Nov 26, 2024

Description ✏️

Closes #xxx

What changed? Feel free to be brief.

  • Bullet points are helpful.
  • Screenshots are helpful (if applicable).

Checklist ✅

  • I have added screenshots (if UI changes are present).
  • I have done a self-review of my code.
  • I have manually tested my code (if applicable).

Important

Adds version check in aiderProcess.ts to conditionally include --no-detect-urls flag based on Aider version.

  • Behavior:
    • Adds getAiderVersion() and compareVersions() in aiderProcess.ts to determine Aider version.
    • Conditionally adds --no-detect-urls flag in buildAiderCommand() if Aider version is >= 0.64.2.
  • Imports:
    • Adds exec import in aiderProcess.ts.
  • Misc:
    • Minor whitespace change in aiderUtil.ts.

This description was created by Ellipsis for 296f019. It will automatically update as commits are pushed.

@nang-dev nang-dev requested review from Fryingpannn and a team as code owners November 26, 2024 04:52
@nang-dev nang-dev merged commit 5ef03fa into main Nov 26, 2024
2 checks passed
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 296f019 in 1 minute and 4 seconds

More details
  • Looked at 81 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. extensions/vscode/src/integrations/aider/aiderProcess.ts:58
  • Draft comment:
    Remove unnecessary console.dir statements used for logging the current version.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of console.dir for logging the current version is unnecessary and should be removed for cleaner code.
2. extensions/vscode/src/integrations/aider/aiderProcess.ts:59
  • Draft comment:
    Remove unnecessary console.dir statements used for logging the current version.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of console.dir for logging the current version is unnecessary and should be removed for cleaner code.
3. extensions/vscode/src/integrations/aider/aiderProcess.ts:38
  • Draft comment:
    Consider improving error handling in getAiderVersion function to provide user feedback or retry mechanism.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The error handling in getAiderVersion function logs the error but does not provide any user feedback or retry mechanism. Consider improving error handling.
4. extensions/vscode/src/integrations/aider/aiderUtil.ts:50
  • Draft comment:
    Remove unnecessary space added in line 50.
  • Reason this comment was not posted:
    Confidence changes required: 10%
    The added space in line 50 is unnecessary and should be removed for cleaner code.

Workflow ID: wflow_SWSOuaiRZeciE5nO


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

nang-dev added a commit that referenced this pull request Feb 4, 2025
* Fixed build

* Added working

* Added --no-detect-urls

---------

Co-authored-by: nang-dev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant