[FIX] Bug fixes and optimizations #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xes-and-optimizations
charlwillia6
requested review from
nang-dev,
Fryingpannn and
a team
as code owners
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 02d032e in 1 minute and 28 seconds
More details
- Looked at
122lines of code in7files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. extensions/vscode/src/autocomplete/lsp.ts:62
- Draft comment:
Unnecessary use ofas stringsinceoldestKeyis already a string. Consider removing it. - Reason this comment was not posted:
Confidence changes required:50%
The use ofas anyingotoCache.delete(oldestKey as string);is unnecessary sinceoldestKeyis already a string. This can be simplified.
Workflow ID: wflow_P7nGKBTveNUJTPDT
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
charlwillia6
changed the title
Himanshu-Singh-Chauhan
approved these changes
Jan 31, 2025
nang-dev
pushed a commit
that referenced
this pull request
Feb 4, 2025
* Fix: Improve path handling, LSP error logging, and React component keys * Refactor: Add `isLast` prop to markdown preview components --------- Co-authored-by: cwilliams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✏️
Fixes miscellaneous issue that occurred while building the project and running it in the debugger. There were several issues with unique keys and paths. Also, there was an error with the use of "name" in lsp.ts. This PR fixes those issues. Some of these issues may only effect Windows users, but I did test to make sure that they are cross-platform.
Checklist ✅
Important
Fixes unique key, path handling, and error handling issues across multiple files, with minor optimizations and refactoring.
InventoryPreview.tsxby changing key to${item.command}-${index}.paths.tsby converting Windows paths to file URL format.executeGotoProvider()inlsp.tsby usinginput.nameinstead ofname.type: "module"topackage.jsoncreation inpaths.ts.VsCodeExtension.ts.autocomplete.ts.This description was created by
for 02d032e. It will automatically update as commits are pushed.