[FIX] Current File Path Issue with Output Console #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrent-file-path-issue
Prevents invalid file paths from appearing in the Current File button when clicking on non-file editors like Output panel or Terminal. Now checks editor's URI scheme to ensure it's a valid file before updating the active file path.
charlwillia6
requested review from
nang-dev,
Fryingpannn and
a team
as code owners
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to 89fa444 in 11 seconds
More details
- Looked at
27lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. gui/src/redux/slices/uiStateSlice.ts:61
- Draft comment:
The comment can be improved for clarity. Consider changing it to:// Set active file path only if it's a non-empty string - Reason this comment was not posted:
Confidence changes required:10%
The change in thesetActiveFilePathreducer is correct, but the comment can be improved for clarity.
Workflow ID: wflow_gmd47qpwChcUcQbn
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
Himanshu-Singh-Chauhan
approved these changes
Jan 31, 2025
nang-dev
pushed a commit
that referenced
this pull request
Feb 4, 2025
Prevents invalid file paths from appearing in the Current File button when clicking on non-file editors like Output panel or Terminal. Now checks editor's URI scheme to ensure it's a valid file before updating the active file path. Co-authored-by: cwilliams <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description ✏️
Fixes an issue where the Current File would change to
extension-output-pearai.pearai-#1-PearAIif you clicked on the output console or the output console tab.This fix will make sure that only valid file paths are allowed and shown for the Current File feature.
Checklist ✅
Important
Fixes invalid current file path issue when interacting with VSCode output console by ensuring only valid file paths are set.
VsCodeIdeclass inideProtocol.ts.setActiveFilePathinuiStateSlice.ts.editor?.document.uri.scheme === 'file'inonDidChangeActiveTextEditorinideProtocol.ts.setActiveFilePathto only set non-empty strings inuiStateSlice.ts.This description was created by
for 89fa444. It will automatically update as commits are pushed.