Numerous improvements to Gogstash #126
Conversation
Updating from Tsaikd
Updating from source
| @@ -26,6 +26,10 @@ type InputConfig struct { | |||
| Key string `json:"key"` // where to get data, default: "gogstash" | |||
| Connections int `json:"connections"` // maximum number of socket connections, default: 10 | |||
| BatchCount int `json:"batch_count"` // The number of events to return from Redis using EVAL, default: 125 | |||
| //Adding support to password protected redis server | |||
There was a problem hiding this comment.
We should have a space after //
| @@ -27,6 +27,10 @@ type OutputConfig struct { | |||
| Timeout int `json:"timeout,omitempty"` | |||
| ReconnectInterval int `json:"reconnect_interval,omitempty"` | |||
| Connections int `json:"connections"` // maximum number of socket connections, default: 10 | |||
| //Adding support to password protected redis server | |||
There was a problem hiding this comment.
3: Added compiled binaries
https://github.com/tsaikd/gogstash/releases
4: Added compilation script to generate binaries
docker/Dockerfile should be able to help to build the project.
Normally I wouldn't create pull requests this way. But as I have already done the changes for my internal project, just sharing them here as well.
Feel free to cherry-pick.
If you don't like the normal PR flow, you can just close the PR. I will cherry-pick some commits and make a few changes.
| @@ -22,6 +22,13 @@ input: | |||
|
|
|||
| # (optional) BLPOP blocking timeout, default: "600s" | |||
| blocking_timeout: "600s" | |||
|
|
|||
| # (optional) Password for DB, default: null | |||
There was a problem hiding this comment.
The type of password is string, so I think the default value is an empty string "".
| @@ -23,6 +23,12 @@ gogstash output redis | |||
|
|
|||
| // (optional), in seconds, default: 1 | |||
| "reconnect_interval": 1 | |||
|
|
|||
| // (optional) Password for DB, default: null | |||
There was a problem hiding this comment.
The type of password is string, so I think the default value is an empty string "".
Updated the code
1: Added Redis output
2: Added password support to Redis
3: Added compiled binaries
4: Added compilation script to generate binaries
5: Updated documentation with new features
6: Added flags to improve elastic compatibility.
Normally I wouldn't create pull requests this way. But as I have already done the changes for my internal project, just sharing them here as well.
Feel free to cherry-pick.