Skip to content

Commit

Permalink
8337339
Browse files Browse the repository at this point in the history
Hi all,

  please review this simple change to not run the Test*SizeFlags tests with -Xcomp to avoid timeouts. I do not expect any new insights running these tests with -Xcomp, so I agree that it is easiest to just not run them with that flag.

Testing: gha

Hth,
  Thomas
  • Loading branch information
tschatzl committed Oct 15, 2024
1 parent a601cd2 commit fdc2f59
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions test/hotspot/jtreg/gc/arguments/TestG1HeapSizeFlags.java
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
* @summary Tests argument processing for initial and maximum heap size for the G1 collector
* @key flag-sensitive
* @requires vm.gc.G1 & vm.opt.MinHeapSize == null & vm.opt.MaxHeapSize == null & vm.opt.InitialHeapSize == null
* @requires vm.compMode != "Xcomp"
* @library /test/lib
* @library /
* @modules java.base/jdk.internal.misc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
* parallel collectors.
* @key flag-sensitive
* @requires vm.gc.Parallel & vm.opt.MinHeapSize == null & vm.opt.MaxHeapSize == null & vm.opt.InitialHeapSize == null
* @requires vm.compMode != "Xcomp"
* @library /test/lib
* @library /
* @modules java.base/jdk.internal.misc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
* @summary Tests argument processing for initial and maximum heap size for the Serial collector
* @key flag-sensitive
* @requires vm.gc.Serial & vm.opt.MinHeapSize == null & vm.opt.MaxHeapSize == null & vm.opt.InitialHeapSize == null
* @requires vm.compMode != "Xcomp"
* @library /test/lib
* @library /
* @modules java.base/jdk.internal.misc
Expand Down

0 comments on commit fdc2f59

Please sign in to comment.