Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: special honor to full timers #58

Merged
merged 6 commits into from
Feb 19, 2025
Merged

fix: special honor to full timers #58

merged 6 commits into from
Feb 19, 2025
+141 −56

Conversation

Ayushjhawar8
Copy link
Contributor

@Ayushjhawar8 Ayushjhawar8 commented Feb 12, 2025 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Feb 12, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
contribution-tracker ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2025 8:53am

seveibar
seveibar reviewed Feb 13, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok but you should still show the star count and allow the full timers to be clicked etc

Anshgrover23
Anshgrover23 requested changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayushjhawar8 add the latest screenshots in description.

seveibar
seveibar approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hehe i like it

@seveibar
Copy link
Contributor

btw these heads are crushed

image

@Ayushjhawar8
Copy link
Contributor Author

will fix that asap

@seveibar
Copy link
Contributor

@Ayushjhawar8 actually, why is it designed like that? The avatar should be on the same line as the name

@seveibar
Copy link
Contributor

image

@Ayushjhawar8
Copy link
Contributor Author

Ayushjhawar8 commented Feb 18, 2025 •
edited
Loading

@seveibar
image

is something like this looks good?

Anshgrover23
Anshgrover23 requested changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@Anshgrover23 Anshgrover23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayushjhawar8 now the pr no with its icon is not aligned well
image
CC: @seveibar

@seveibar seveibar merged commit 9e19ecb into tscircuit:main Feb 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anshgrover23 Anshgrover23 Anshgrover23 requested changes

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the Full timers from the Podium
3 participants
@Ayushjhawar8 @seveibar @Anshgrover23