add maxVoltageRating to capacitor #629
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Anshgrover23
requested review from
seveibar and
imrishabh18
and removed request for
seveibar
There was a problem hiding this comment.
It’s a bit odd to display the max voltage on the schematic imo
sometimes its done but its actually quite confusing when mixed with simulation.
i think its sometimes important, we could introduce schShowRatings to enable it to be displayed but it should default to off i think
There was a problem hiding this comment.
I think what @seveibar meant with the schShowRatings prop was, that it should be a parent level prop. Like in board or group
|
@imrishabh18 no, i dont know about that because he merged my this prop pr tscircuit/props#182 so is this also wrong. or only in core we need to change. |
@imrishabh18 it's not a bad idea for a top level prop but it's fine here too. We will probably have a "showRatings" mode at a subcircuit level at some point because it also makes sense there |
|
🎉🎈 @Anshgrover23 has been awarded $3! 🎈🎊 |
Fixes #622