feat: Add support for pill shaped holes #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seveibar
approved these changes
Dec 3, 2024
imrishabh18
force-pushed
the
feat/add-pill-support
branch
from
2f13150 to
dd5ac80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue - #41
This add support for the pill shaped
plated_holes.More work needed in future
Note: We are good now, cause in the first flow of circuit_json to dsn the dimension of the pill is correctly mapped to the dsn which will used in routing and we will then be extracting the trace's. Currently, when we are processing the dsnJson back, then we are adding this just as a rect
pcb_smtpad. We need to have a function which createsplated_holeby some logic of finding name ofHolein imageName and then converting that toplated_hole. Created an issue for this - #48PS: The plated_hole shape
Ovalis not added here because of the issue in footprint of it - tscircuit/tscircuit.com#342