fix merge dsn session to have SVG parity #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main idea behind this work is to make sure that converting Circuit JSON to DsnPcb AND DsnSession can successfully be converted BACK into an identical-looking Circuit JSON. We can use this test to make sure the ids stay consistent!!!
Prior to this test and the last two PRs, the dsn-converter could not convert Circuit JSON to DsnPcb and DsnSession then back again without changing the circuit. Something was always lost or changed, e.g. missing vias or flipped traces
This type of test can be written for other examples to make sure we can successfully convert things back and forth, for example it could be used to "recreate" oval shaped holes or multi-layer traces (traces with inner layers) etc.