feat support rotation #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abse2001
requested review from
seveibar and
imrishabh18
and removed request for
seveibar
|
the smoothie board needs more work |
Abse2001
commented
Feb 12, 2025
There was a problem hiding this comment.
the smoothiboard is using another DSN format freerouting support both specctra and Electra DSN which is the smoothie board is using Specctra (not 100% sure still learning the def between the 2) while we are parsing using Electra I think ?
There was a problem hiding this comment.
oh interesting, i had no idea.... that's a very important discovery CC @imrishabh18 !!!!!!
|
@Abse2001 Looks okay to me |
seveibar
reviewed
Feb 13, 2025
|
@seveibar yeah so from what I understand the smoothie board is using a different way for rotation and placement of pins, (not 100% sure but, I will do more investigation today) but yeah Im going to work on that next. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/claim #77
/close #77