-
Notifications
You must be signed in to change notification settings - Fork 12
Conversation
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
So I think |
3a516be
to
0d33e4b
Compare
@seveibar Take a look now, I think this is a good place to start. We can either add the plugins config in this object |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok i do like where this is going. Can you remove eslint from the top level since we use biome (biome doesnt support plugins so eslint is better for target projects)
lib/util/tscircuitLinter.ts
Outdated
@@ -0,0 +1,112 @@ | |||
import * as ts from 'typescript'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the naming convention for this project is supposed to be ExportNameExact
or kebab-case
(usually kebab-case). Also the file name should always match the export, tscircuitLinter.ts
should be lint-project.ts
FWIW I generally believe these rules shouldn't be enforced if there isn't a linter running on ci... so feel free to ignore suggestion to rename
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! It's okay, I will rename. If the codebase is following a standard practice, then it's fine to follow it thoroughly.
Lint error shown
Closes issue - #13