Skip to content

Add support for 24hr-averaged ocn/ice products (#3535) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2025

Conversation

tsga
Copy link
Owner

@tsga tsga commented May 1, 2025

Add full capability to produce 24-hr ocean and ice products. In particular, fixing a bug where the CICE history files are missing when cycle is not t00z and when FHOUT_ICE is 24. This fix has been made possible since the changes from UFSWM PR #2437 have been merged and the GW PR NOAA-EMC#3145 updated the UFSWM hash to include these UFSWM updates for global-workflow.

Resolves NOAA-EMC#2674

Description

Type of change

  • Bug fix (fixes something broken)
  • New feature (adds functionality)
  • Maintenance (code refactor, clean-up, new CI test, etc.)

Change characteristics

  • Is this a breaking change (a change in existing functionality)? YES/NO
  • Does this change require a documentation update? YES/NO
  • Does this change require an update to any of the following submodules? YES/NO (If YES, please add a link to any PRs that are pending.)
    • EMC verif-global
    • GDAS
    • GFS-utils
    • GSI
    • GSI-monitor
    • GSI-utils
    • UFS-utils
    • UFS-weather-model
    • wxflow

How has this been tested?

Checklist

  • Any dependent changes have been merged and published
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have documented my code, including function, input, and output descriptions
  • My changes generate no new warnings
  • New and existing tests pass with my changes
  • This change is covered by an existing CI test or a new one has been added
  • Any new scripts have been added to the .github/CODEOWNERS file with owners
  • I have made corresponding changes to the system documentation if necessary

Add full capability to produce 24-hr ocean and ice products. In
particular, fixing a bug where the CICE history files are missing
when `cycle` is not `t00z` and when `FHOUT_ICE` is `24`. This fix has
been made possible since the changes from [UFSWM PR
#2437](ufs-community/ufs-weather-model#2437)
have been merged and the GW PR #3145 updated the UFSWM hash to include
these UFSWM updates for global-workflow.

Resolves #2674
@tsga tsga marked this pull request as ready for review May 1, 2025 20:58
@tsga tsga merged commit 5cfbf48 into tsga:feature/land_iau May 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants