Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode numpy arrays in sample batch json #965

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

benjeffery
Copy link
Member

No description provided.

@benjeffery
Copy link
Member Author

Needs some tests

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 54.54545% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.09%. Comparing base (a080e8f) to head (fe04950).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
tsinfer/inference.py 54.54% 4 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #965      +/-   ##
==========================================
- Coverage   93.16%   93.09%   -0.08%     
==========================================
  Files          18       18              
  Lines        6337     6345       +8     
  Branches     1133     1135       +2     
==========================================
+ Hits         5904     5907       +3     
- Misses        294      298       +4     
- Partials      139      140       +1     
Flag Coverage Δ
C 93.09% <54.54%> (-0.08%) ⬇️
python 95.43% <54.54%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjeffery benjeffery marked this pull request as ready for review September 6, 2024 15:39
@benjeffery benjeffery merged commit ed64181 into tskit-dev:main Sep 6, 2024
10 of 12 checks passed
@benjeffery benjeffery deleted the fix-json branch September 6, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant