ga label #102
Merged
ga label #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
### ウォークスルー
この変更は、GitHubラベルの名前と説明を簡略化し、新しいラベルを追加しています。また、ワークフローのラベル形式をシンプルにし、`VALID_LABELS`の定義を改善しました。
### 変更点
| ファイル | 要約 |
| --- | --- |
| .github/labels.json | GitHubラベルの名前と説明を変更し、新しいラベル（`refactor`, `chore`, `documentation`）を追加。既存ラベルの名前を簡略化。 |
| .github/workflows/auto-comment-on-unlabeled-issue.yml | ラベルの形式を簡略化し、コメントメッセージを更新。 |
| .github/workflows/create-branch-on-issue-assign.yml | `VALID_LABELS`の定義をスペース区切りからパイプ区切りに変更し、`grep`コマンドで正規表現を使用するよう修正。`question`ラベルを削除し、コメント末尾に改行を追加。 |Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (3)
- .github/labels.json (1)
- .github/workflows/auto-comment-on-unlabeled-issue.yml (2)
- .github/workflows/create-branch-on-issue-assign.yml (2)
Review comments generated (33)
- Review: 2
- LGTM: 31
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
Comment on lines
+47
to
+48
| VALID_LABELS="bug|feature|enhancement|documentation|refactor|chore" | ||
| BRANCH_LABEL=$(echo "$LABELS" | tr ' ' '\n' | grep -m1 -E "$VALID_LABELS") |
There was a problem hiding this comment.
grepコマンドの正規表現を使用するために、-Eオプションが追加されていますが、trコマンドでスペースを改行に変換しているため、grep -m1 -wのままで問題ありません。変更は不要です。
- VALID_LABELS="bug|feature|enhancement|documentation|refactor|chore"
- BRANCH_LABEL=$(echo "$LABELS" | tr ' ' '\n' | grep -m1 -E "$VALID_LABELS")
+ VALID_LABELS="bug feature enhancement documentation refactor chore"
+ BRANCH_LABEL=$(echo "$LABELS" | tr ' ' '\n' | grep -m1 -w "$VALID_LABELS")
Comment on lines
+18
to
21
| "name": "question", | ||
| "color": "d876e3", | ||
| "description": "Further information is requested" | ||
| }, |
There was a problem hiding this comment.
questionラベルは削除されるべきですが、ここではまだ存在しています。.github/workflows/create-branch-on-issue-assign.ymlの変更と矛盾しています。
- "name": "question",
- "color": "d876e3",
- "description": "Further information is requested"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit