Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tagg #672

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Feature/tagg #672

merged 2 commits into from
Mar 4, 2025

Conversation

ttizze
Copy link
Owner

@ttizze ttizze commented Mar 4, 2025

Summary by CodeRabbit

  • New Features
    • The tag selection interface now presents each tag with its associated page count, giving users clearer context when editing pages.

Copy link

coderabbitai bot commented Mar 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the tag data representation across the application. Tag-related components, tests, and database queries now use an enhanced structure, replacing the original "allTags" property with "allTagsWithCount" to include page count details. Function signatures, interfaces, and test mocks have been updated, and the database query function is renamed and modified to retrieve and sort the new tag information.

Changes

Files Summary of Changes
next/src/app/[locale]/…/edit/_components/edit-page-client.tsx
next/src/app/[locale]/…/edit/_components/tag-input/index.tsx
next/src/app/[locale]/…/edit/_components/tag-input/index.test.tsx
Replaced the "allTags" prop with "allTagsWithCount" and updated its type from Tag[] to TagWithCount[]. Modified component logic to format tag labels with associated page counts and updated test mocks accordingly.
next/src/app/[locale]/…/edit/_db/queries.server.ts
next/src/app/[locale]/…/edit/page.tsx
Renamed the database query function from getAllTags to getAllTagsWithCount, modified it to fetch tag counts, and updated data retrieval to use the new function and property naming.

Sequence Diagram(s)

sequenceDiagram
    participant DB as Database
    participant Q as queries.server.ts
    participant P as page.tsx (getPageData)
    participant E as EditPageClient
    participant T as TagInput

    DB ->> Q: Execute query for tags with counts
    Q -->> DB: Return tag data (id, name, count)
    P ->> Q: Call getAllTagsWithCount()
    Q -->> P: Return tags with count
    P ->> E: Pass allTagsWithCount
    E ->> T: Forward allTagsWithCount
    T -->> E: Render tag options ("name (count)")
Loading

Possibly related PRs

Poem

I hopped through lines of code so bright,
With tags counted in a brand new light,
From mock to query, the changes are clear,
A bunny’s delight in every new gear,
Hopping through updates with joy in sight! 🐰✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0005743 and ded2a04.

📒 Files selected for processing (5)
  • next/src/app/[locale]/(edit-layout)/user/[handle]/page/[slug]/edit/_components/edit-page-client.tsx (3 hunks)
  • next/src/app/[locale]/(edit-layout)/user/[handle]/page/[slug]/edit/_components/tag-input/index.test.tsx (5 hunks)
  • next/src/app/[locale]/(edit-layout)/user/[handle]/page/[slug]/edit/_components/tag-input/index.tsx (2 hunks)
  • next/src/app/[locale]/(edit-layout)/user/[handle]/page/[slug]/edit/_db/queries.server.ts (1 hunks)
  • next/src/app/[locale]/(edit-layout)/user/[handle]/page/[slug]/edit/page.tsx (3 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@ttizze ttizze merged commit 20cc2d1 into main Mar 4, 2025
3 of 5 checks passed
@ttizze ttizze deleted the feature/tagg branch March 4, 2025 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant