Always use unsigned dimension values for AIS PGNs - #487
Open
wellenvogel wants to merge 4 commits into
Open
Conversation
wellenvogel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently received an issue for my converter. After some analyzing I found that the N2K devices where sending AIS PGNs 129794 where the Fields PosRefStbd and PosRefBow where set to 0xffff - indicating "unset". With the current implementation the library did not detect this as "unset" - but returned a large value. Comparing this with canboat I saw that canboat is using the type LENGTH_UFIX16_DM_FIELD for all the dimension related PGNs (129794, 129040, 129041, 129810, 130842).
When analyzing the current code I found that the handling already is slightly inconsistent - SetN2kPGN129041 already uses unsigned values, set/Parse for 129810 already use unsigned values - the others use signed values.
This PR tries to correct this and uses unsigned values for all handled PGNs.