fix(cmake): Fix static build #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvonelm
force-pushed
the
fix-static-builds
branch
from
86dc06c to
7414afc
Compare
bmario
requested changes
Nov 25, 2024
cmake/FindAudit.cmake
Outdated
Comment on lines
40
to
49
| if(Audit_USE_STATIC_LIBS) | ||
| try_compile(BUILD_AUDIT | ||
| SOURCES "${CMAKE_CURRENT_LIST_DIR}/test_static_audit.c" | ||
| LINK_LIBRARIES ${Audit_STATIC_LIBRARIES} | ||
| COMPILE_DEFINITIONS "-static") | ||
| if(NOT BUILD_AUDIT) | ||
| set(Audit_FOUND OFF CACHE INTERNAL "") | ||
| endif() | ||
| endif() | ||
| add_library(Audit::Audit ALIAS PkgConfig::Audit) |
There was a problem hiding this comment.
I think you have to define your own target if static should be used. I'd assume PkgConfig::Audit always links the shared lib?
cmake/FindRadare.cmake
Outdated
Comment on lines
41
to
50
| if(Radare_USE_STATIC_LIBS) | ||
| try_compile(BUILD_RADARE | ||
| SOURCES "${CMAKE_CURRENT_LIST_DIR}/test_static_radare.c" | ||
| LINK_LIBRARIES ${Radare_STATIC_LIBRARIES} | ||
| COMPILE_DEFINITIONS "-static") | ||
| if(NOT BUILD_RADARE) | ||
| set(Radare_FOUND OFF CACHE INTERNAL "") | ||
| endif() | ||
| endif() | ||
| add_library(Radare::Radare ALIAS PkgConfig::Radare) |
There was a problem hiding this comment.
Same as with the audit target. you likely need your own target to link against the static libs.
cvonelm
force-pushed
the
fix-static-builds
branch
from
7414afc to
692eac9
Compare
bmario
requested changes
Jan 22, 2025
cmake/FindRadare.cmake
Outdated
|
|
||
| if(PkgConfig_FOUND) | ||
| # Breaking API changes in 5.8.0 | ||
| pkg_check_modules(Radare IMPORTED_TARGET r_main>=5.8.0) |
There was a problem hiding this comment.
cvonelm
force-pushed
the
fix-static-builds
branch
from
692eac9 to
ece1956
Compare
Some libraries were not correctly (or at all) checking for static variants if lo2s_USE_STATIC_LIBS was requested, so I fixed that.
cvonelm
force-pushed
the
fix-static-builds
branch
from
ece1956 to
2e52d3f
Compare
bmario
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some libraries were not correctly (or at all) checking for static variants if lo2s_USE_STATIC_LIBS was requested, so I fixed that.