start group overlay button to look like a real button

Author: kodewdle

ElvUI/Core/Modules/Skins/Skins.lua

@@ -762,6 +762,64 @@ do
 	end
 end
 
+do
+	local overlays = {}
+
+	local function OverlayHide(button)
+		local overlay = overlays[button]
+		if not overlay then return end
+
+		overlay:Hide()
+	end
+
+	local function OverlayShow(button)
+		local overlay = overlays[button]
+		if not overlay then return end
+
+		overlay:ClearAllPoints()
+		overlay:SetPoint(button:GetPoint())
+		overlay:Show()
+	end
+
+	local function OverlayOnEnter(overlay)
+		overlay.text:SetTextColor(1, 1, 1)
+		S:SetBackdropBorderColor(overlay, 'OnEnter')
+	end
+
+	local function OverlayOnLeave(overlay)
+		overlay.text:SetTextColor(1, 0.81, 0)
+		S:SetBackdropBorderColor(overlay, 'OnLeave')
+	end
+
+	function S:OverlayButton(button, name, text, textLayer, level, strata)
+		if overlays[button] then return end -- already exists
+
+		local width, height = button:GetSize()
+		local overlay = CreateFrame('Frame', 'ElvUI_OverlayButton_'..name, E.UIParent)
+		overlay:Size(width, height)
+		overlay:SetTemplate(nil, true)
+		overlay:SetPoint(button:GetPoint())
+		overlay:SetFrameLevel(level or 10)
+		overlay:SetFrameStrata(strata or 'MEDIUM')
+		overlay:Hide()
+
+		local txt = overlay:CreateFontString(nil, textLayer or 'OVERLAY')
+		txt:SetPoint('CENTER')
+		txt:FontTemplate()
+		txt:SetText(text)
+		txt:SetTextColor(1, 0.81, 0)
+		overlay.text = txt
+
+		overlay:SetScript('OnEnter', OverlayOnEnter)
+		overlay:SetScript('OnLeave', OverlayOnLeave)
+
+		button:HookScript('OnHide', OverlayHide)
+		button:HookScript('OnShow', OverlayShow)
+
+		overlays[button] = overlay
+	end
+end
+
 function S:HandleButton(button, strip, isDecline, noStyle, createBackdrop, template, noGlossTex, overrideTex, frameLevel, regionsKill, regionsZero, isFilterButton, filterDirection)
 	assert(button, 'doesn\'t exist!')
 

ElvUI/Mainline/Modules/Skins/LFG.lua

@@ -434,27 +434,7 @@ function S:LookingForGroupFrames()
 	S:HandleButton(LFGListFrame.SearchPanel.SignUpButton)
 
 	-- Monitor this button, this seems NOT to taint. But who knows
-	local StartGroupButton = LFGListFrame.SearchPanel.ScrollBox.StartGroupButton
-	local bu = CreateFrame("Frame", "StartGroupButton", E.UIParent)
-	bu:SetFrameLevel(10)
-	bu:SetFrameStrata("HIGH")
-	bu:Size(135,22)
-	bu:SetTemplate()
-	bu:SetPoint(StartGroupButton:GetPoint())
-	bu.text = bu:CreateFontString(nil, "OVERLAY", "GameFontHighlight")
-	bu.text:SetPoint("CENTER")
-	bu.text:FontTemplate()
-	bu.text:SetText(_G.START_A_GROUP)
-	bu:Hide()
-
-	StartGroupButton:HookScript("OnHide", function()
-		bu:Hide()
-	end)
-	StartGroupButton:HookScript("OnShow", function()
-		bu:ClearAllPoints()
-		bu:SetPoint(StartGroupButton:GetPoint())
-		bu:Show()
-	end)
+	S:OverlayButton(LFGListFrame.SearchPanel.ScrollBox.StartGroupButton, 'StartGroupButton', _G.START_A_GROUP, nil, nil, 'HIGH')
 
 	LFGListFrame.SearchPanel.BackButton:ClearAllPoints()
 	LFGListFrame.SearchPanel.BackButton:Point('BOTTOMLEFT', -1, 3)