-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(bigbluebutton-integration): features to support integration with bigbluebutton's recent h5p plugin #156
base: master
Are you sure you want to change the base?
Changes from all commits
b7be991
17045ec
0c2a221
9020122
6adacea
8b78b29
0d6db21
5f228c2
dc94f75
6779592
5d9e883
705c5f3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -13,7 +13,7 @@ jobs: | |
|
||
strategy: | ||
matrix: | ||
node: [ 14, 16, 18 ] | ||
node: [ 18, 20, 22 ] | ||
|
||
steps: | ||
- name: Checkout | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import { defineConfig } from 'cypress' | ||
|
||
export default defineConfig({ | ||
e2e: { | ||
// We've imported your old cypress plugins here. | ||
// You may want to clean this up later by importing these. | ||
setupNodeEvents(on, config) { | ||
return require('./cypress/plugins/index.js')(on, config) | ||
}, | ||
}, | ||
}) |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -226,6 +226,8 @@ H5P.init = function (target) { | |
|
||
var saveTimer, save = function () { | ||
var state = instance.getCurrentState(); | ||
if ( H5PIntegration.saveFunctionCallback instanceof Function || | ||
typeof H5PIntegration.saveFunctionCallback === 'function') H5PIntegration.saveFunctionCallback(state); | ||
Comment on lines
+229
to
+230
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changes to files in the vendor directory should be done on the upstream package, as this makes the maintenance and updating of those dependencies much easier going forward without having to manually carry over changes, thereby reducing technical debt over time. |
||
if (state !== undefined) { | ||
H5P.setUserData(contentId, 'state', state, {deleteOnChange: true}); | ||
} | ||
|
@@ -2461,7 +2463,7 @@ H5P.createTitle = function (rawTitle, maxLength) { | |
* Callback with error as parameters. | ||
* @param {boolean} [extras.async=true] | ||
*/ | ||
H5P.setUserData = function (contentId, dataId, data, extras) { | ||
H5P.setUserData = function (contentId, dataId, data, extras, saveState = false) { | ||
var options = H5P.jQuery.extend(true, {}, { | ||
subContentId: 0, | ||
preloaded: true, | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Catching an error without either rethrowing it or breaking from the function will cause execution to continue, which will lead to unexpected behavior or errors further down the code.