Add tables aws_quicksight_user, aws_quicksight_namespace, aws_quicksight_group, aws_quicksight_data_source, aws_quicksight_data_set, aws_quicksight_vpc_connection and aws_quicksight_account_settings Closes #2457#2467
Merged
Conversation
…ght_group, aws_quicksight_datasource, aws_quicksight_dataset and aws_quicksight_account_settings Closes #2457
…ataset and datasource to use data_set and data_source
Contributor
There was a problem hiding this comment.
Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.
Files not reviewed (1)
- go.mod: Language not supported
Comments suppressed due to low confidence (1)
aws/table_aws_quicksight_data_source.go:17
- [nitpick] Consider renaming the function to 'tableAwsQuickSightDataSource' (with an uppercase 'S' in 'Source') to match the table name 'aws_quicksight_data_source' and maintain consistent naming conventions across the codebase.
func tableAwsQuickSightDatasource(_ context.Context) *plugin.Table {
misraved
reviewed
Apr 11, 2025
Contributor
misraved
left a comment
There was a problem hiding this comment.
Please take a look at the review comment
…where clause wherever required
misraved
approved these changes
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test logs
Logs
Example query results
Results