Skip to content

Add tables aws_quicksight_user, aws_quicksight_namespace, aws_quicksight_group, aws_quicksight_data_source, aws_quicksight_data_set, aws_quicksight_vpc_connection and aws_quicksight_account_settings Closes #2457#2467

Merged
misraved merged 16 commits into
mainfrom
issue-2457
Apr 11, 2025

Conversation

@ParthaI
Copy link
Copy Markdown
Contributor

@ParthaI ParthaI commented Apr 9, 2025

Integration test logs

Logs
Add passing integration test logs here

Example query results

Results
> select
  name,
  arn,
  identity_store,
  capacity_region
from
  aws_quicksight_namespace
where
  creation_status = 'CREATED';
+---------+-------------------------------------------------------------+----------------+-----------------+
| name    | arn                                                         | identity_store | capacity_region |
+---------+-------------------------------------------------------------+----------------+-----------------+
| default | arn:aws:quicksight:us-east-1:xxxxxxxxxxxx:namespace/default | QUICKSIGHT     | us-east-1       |
+---------+-------------------------------------------------------------+----------------+-----------------+

Time: 0.5s. Rows returned: 0. Rows fetched: 1. Hydrate calls: 0.

Scans:
  1) aws_quicksight_namespace.aws: Time: 386ms. Fetched: 1. Hydrates: 0. Quals: creation_status=CREATED.


> select
  region,
  count(*) as group_count,
  array_agg(group_name) as groups
from
  aws_quicksight_group
group by
  region;
+-----------+-------------+------------------------+
| region    | group_count | groups                 |
+-----------+-------------+------------------------+
| us-east-1 | 1           | test-quicksight-group1 |
+-----------+-------------+------------------------+


> select
  name,
  data_source_id,
  status,
  data_source_parameters
from
  aws_quicksight_datasource
where
  type = 'S3';
+--------------------------------+--------------------------------------+---------------------+----------------------------------------------------------------->
| name                           | data_source_id                       | status              | data_source_parameters                                          >
+--------------------------------+--------------------------------------+---------------------+----------------------------------------------------------------->
| Business Review                | 6971fd92-d73c-4885-b2e4-028370fc865d | CREATION_SUCCESSFUL | {"Value":{"ManifestFileLocation":{"Bucket":"spaceneedle-samplefi>
| MyCostReport                   | 7f0a9442-2648-46a3-b6eb-51b64410457e | CREATION_SUCCESSFUL | {"Value":{"ManifestFileLocation":{"Bucket":"ved-billing-bucket",>
| People Overview                | e5a5f9dd-3182-4bbc-956b-9b44f9e5240c | CREATION_SUCCESSFUL | {"Value":{"ManifestFileLocation":{"Bucket":"spaceneedle-samplefi>
| Sales Pipeline                 | 5b89c34d-f51f-44c9-81c4-3e9ce4573c1e | CREATION_SUCCESSFUL | {"Value":{"ManifestFileLocation":{"Bucket":"spaceneedle-samplefi>
| Web and Social Media Analytics | 652cec10-0746-4ae7-90ac-aa546dc77b0c | CREATION_SUCCESSFUL | {"Value":{"ManifestFileLocation":{"Bucket":"spaceneedle-samplefi>
+--------------------------------+--------------------------------------+---------------------+---------------------------------------------------------------


> select
  name,
  dataset_id,
  created_time,
  import_mode
from
  aws_quicksight_dataset
order by
  created_time desc
limit 10;
+--------------------------------+--------------------------------------+---------------------------+-------------+
| name                           | dataset_id                           | created_time              | import_mode |
+--------------------------------+--------------------------------------+---------------------------+-------------+
| Sales Pipeline                 | 565f263e-aab2-4767-8259-f368068a8008 | 2025-04-09T11:10:02+05:30 | SPICE       |
| Web and Social Media Analytics | 43995c69-17f2-4114-9f51-b5fc98391cbc | 2025-04-09T11:10:02+05:30 | SPICE       |
| Business Review                | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | 2025-04-09T11:10:02+05:30 | SPICE       |
| People Overview                | 5511ba6e-9a84-4d53-be5a-9e03ee8f6357 | 2025-04-09T11:10:02+05:30 | SPICE       |
| MyCostReport                   | 7f0a9442-2648-46a3-b6eb-51b64410457e | 2025-04-02T18:28:06+05:30 | SPICE       |
+--------------------------------+--------------------------------------+---------------------------+-------------+


> select
  name,
  dataset_id,
  o ->> 'Name' as column_name,
  o ->> 'Type' as data_type
from
  aws_quicksight_dataset,
  jsonb_array_elements(output_columns) as o
where
  dataset_id = 'eb6c5720-42a2-45a9-9d17-e0083a2d8061';
+-----------------+--------------------------------------+-----------------+-----------+
| name            | dataset_id                           | column_name     | data_type |
+-----------------+--------------------------------------+-----------------+-----------+
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Date            | DATETIME  |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Customer ID     | STRING    |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Customer Name   | STRING    |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Customer Region | STRING    |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Segment         | STRING    |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Service Line    | STRING    |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Revenue Goal    | DECIMAL   |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Billed Amount   | DECIMAL   |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Cost            | DECIMAL   |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Channel         | STRING    |
| Business Review | eb6c5720-42a2-45a9-9d17-e0083a2d8061 | Distinct ID     | INTEGER   |
+-----------------+--------------------------------------+-----------------+-----------+

> select
  account_name,
  edition,
  default_namespace,
  notification_email
from
  aws_quicksight_account_settings
where
  edition = 'ENTERPRISE';
+--------------+------------+-------------------+--------------------+
| account_name | edition    | default_namespace | notification_email |
+--------------+------------+-------------------+--------------------+
| vedTurbot    | ENTERPRISE | default           | ved@turbot.com     |
+--------------+------------+-------------------+--------------------+

> select
  account_name,
  edition,
  default_namespace,
  notification_email,
  termination_protection_enabled,
  public_sharing_enabled
from
  aws_quicksight_account_settings;
+--------------+------------+-------------------+--------------------+--------------------------------+------------------------+
| account_name | edition    | default_namespace | notification_email | termination_protection_enabled | public_sharing_enabled |
+--------------+------------+-------------------+--------------------+--------------------------------+------------------------+
| vedTurbot    | ENTERPRISE | default           | ved@turbot.com     | true                           | false                  |
+--------------+------------+-------------------+--------------------+--------------------------------+------------------------+

…ght_group, aws_quicksight_datasource, aws_quicksight_dataset and aws_quicksight_account_settings Closes #2457
@ParthaI ParthaI requested a review from misraved April 9, 2025 04:17
@ParthaI ParthaI self-assigned this Apr 9, 2025
@ParthaI ParthaI marked this pull request as draft April 9, 2025 04:17
@ParthaI ParthaI changed the title Add tables aws_quicksight_user, aws_quicksight_namespace, aws_quicksight_group, aws_quicksight_datasource, aws_quicksight_dataset and aws_quicksight_account_settings Closes #2457 WIP Add tables aws_quicksight_user, aws_quicksight_namespace, aws_quicksight_group, aws_quicksight_datasource, aws_quicksight_dataset and aws_quicksight_account_settings Closes #2457 Apr 9, 2025
@ParthaI ParthaI linked an issue Apr 9, 2025 that may be closed by this pull request
@ParthaI ParthaI changed the title WIP Add tables aws_quicksight_user, aws_quicksight_namespace, aws_quicksight_group, aws_quicksight_datasource, aws_quicksight_dataset and aws_quicksight_account_settings Closes #2457 WIP Add tables aws_quicksight_user, aws_quicksight_namespace, aws_quicksight_group, aws_quicksight_data_source, aws_quicksight_data_set, aws_quicksight_vpc_connection and aws_quicksight_account_settings Closes #2457 Apr 10, 2025
@ParthaI ParthaI changed the title WIP Add tables aws_quicksight_user, aws_quicksight_namespace, aws_quicksight_group, aws_quicksight_data_source, aws_quicksight_data_set, aws_quicksight_vpc_connection and aws_quicksight_account_settings Closes #2457 Add tables aws_quicksight_user, aws_quicksight_namespace, aws_quicksight_group, aws_quicksight_data_source, aws_quicksight_data_set, aws_quicksight_vpc_connection and aws_quicksight_account_settings Closes #2457 Apr 10, 2025
@ParthaI ParthaI marked this pull request as ready for review April 10, 2025 16:19
@misraved misraved requested a review from Copilot April 11, 2025 05:35
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 17 out of 18 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • go.mod: Language not supported
Comments suppressed due to low confidence (1)

aws/table_aws_quicksight_data_source.go:17

  • [nitpick] Consider renaming the function to 'tableAwsQuickSightDataSource' (with an uppercase 'S' in 'Source') to match the table name 'aws_quicksight_data_source' and maintain consistent naming conventions across the codebase.
func tableAwsQuickSightDatasource(_ context.Context) *plugin.Table {

Copy link
Copy Markdown
Contributor

@misraved misraved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take a look at the review comment

Comment thread aws/table_aws_quicksight_account_setting.go Outdated
@misraved misraved merged commit db76315 into main Apr 11, 2025
1 check passed
@misraved misraved deleted the issue-2457 branch April 11, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create QuickSight tables

3 participants