Refactor YAML document parsing to handle valid separators closes #341#342
Closed
misraved wants to merge 2 commits into
Closed
Refactor YAML document parsing to handle valid separators closes #341#342misraved wants to merge 2 commits into
misraved wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors YAML document parsing to correctly handle YAML document separators by using a regex-based approach instead of a simple string split. The change prevents false splits on --- that appear inside block scalars or other string values.
Key Changes
- Replaced
strings.Split(string(content), "---")with a newsplitYAMLDocuments()function that uses regex to match valid YAML document separators - Added comprehensive documentation explaining the rationale for the change
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
github-actions
Bot
added
the
stale
misraved
removed
the
stale
Contributor
Author
|
Closing the PR in favour of #349 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example query results
Results