Skip to content

fix: always include filtered matrix item in cache key#898

Merged
pskrbasu merged 1 commit into
turbot:developfrom
pdecat:fix/always_include_filtered_matrix_column_in_cache_key
Feb 25, 2026
Merged

fix: always include filtered matrix item in cache key#898
pskrbasu merged 1 commit into
turbot:developfrom
pdecat:fix/always_include_filtered_matrix_column_in_cache_key

Conversation

@pdecat

@pdecat pdecat commented Oct 31, 2025

Copy link
Copy Markdown
Contributor

Without this PR, when using matrix items (that I'm adding to the OVH plugin in francois2metz/steampipe-plugin-ovh#74), queries such as the following are missing items when removing the filtered matrix item column, and clearing the cache resolves the issue:

> select name, region from ovh_perso.ovh_cloud_storage_s3 where project_id = '2cf14530bc1e4ba5a3ae44fbd4cbe866' and region = 'GRA'
+---------------+--------+
| name          | region |
+---------------+--------+
| test-pdecat-1 | GRA    |
+---------------+--------+
1 row

> select name, region from ovh_perso.ovh_cloud_storage_s3 where project_id = '2cf14530bc1e4ba5a3ae44fbd4cbe866'
+---------------+--------+
| name          | region |
+---------------+--------+
| test-pdecat-1 | GRA    |
+---------------+--------+
1 row

> .cache clear
> select name, region from ovh_perso.ovh_cloud_storage_s3 where project_id = '2cf14530bc1e4ba5a3ae44fbd4cbe866'
+---------------+-------------+
| name          | region      |
+---------------+-------------+
| test-pdecat-1 | GRA         |
| test-pdecat-3 | EU-WEST-PAR |
+---------------+-------------+
2 rows

@pdecat pdecat force-pushed the fix/always_include_filtered_matrix_column_in_cache_key branch from deecacd to 10506aa Compare October 31, 2025 09:29
pdecat added a commit to pdecat/steampipe-plugin-ovh that referenced this pull request Oct 31, 2025
pdecat added a commit to pdecat/steampipe-plugin-ovh that referenced this pull request Nov 3, 2025
pdecat added a commit to pdecat/steampipe-plugin-ovh that referenced this pull request Nov 19, 2025
@github-actions

Copy link
Copy Markdown

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days.

@github-actions github-actions Bot added the stale label Dec 31, 2025
@pdecat

pdecat commented Dec 31, 2025

Copy link
Copy Markdown
Contributor Author

Still current.

@github-actions github-actions Bot removed the stale label Jan 1, 2026
@pdecat pdecat force-pushed the fix/always_include_filtered_matrix_column_in_cache_key branch from 10506aa to 75ab332 Compare February 14, 2026 08:47

@pskrbasu pskrbasu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good to me - very surgical and correct. Thanks @pdecat!

@pskrbasu pskrbasu merged commit 491df79 into turbot:develop Feb 25, 2026
1 of 2 checks passed
@pdecat pdecat deleted the fix/always_include_filtered_matrix_column_in_cache_key branch February 25, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants