Add error handling for action conversion in GuardDutyMapper#138
Closed
Priyanka-Chatterjee-2000 wants to merge 1 commit intomainfrom
Closed
Add error handling for action conversion in GuardDutyMapper#138Priyanka-Chatterjee-2000 wants to merge 1 commit intomainfrom
Priyanka-Chatterjee-2000 wants to merge 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds error handling for conversion functions within the GuardDutyMapper to ensure that any failures encountered during the conversion of action or resource details are reported appropriately.
- Added error handling in multiple switch cases for action conversion
- Added error handling in multiple switch cases for resource conversion
Contributor
|
Errors temporarily ignored in #141 to fix linting while we review which error messages to include here. |
|
This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
github-actions
bot
added
the
stale
|
This PR was closed because it has been stalled for 90 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example query results
Results