Push up to 128 frames in sync #1950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haaawk
force-pushed
the
batch_push
branch
2 times, most recently
from
74ff81b to
458baa4
Compare
penberg
reviewed
Feb 9, 2025
added 3 commits
February 11, 2025 14:59
Now it can push multiple frames at a time but we still push just one at each call. Signed-off-by: Piotr Jastrzebski <[email protected]>
In my tests, this speeds up push 4-5 times. Making push of 300 frames take 4-5s instead of 20s. Signed-off-by: Piotr Jastrzebski <[email protected]>
Signed-off-by: Piotr Jastrzebski <[email protected]>
Signed-off-by: Piotr Jastrzebski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my tests, this speeds up push 4-5 times.
Making push of 300 frames take 4-5s instead of 20s.