Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Precompiled header proposal #5

Open
wants to merge 50 commits into
base: master
Choose a base branch
from

Conversation

fabiencastan
Copy link
Member

No description provided.

…ofx/sconsProject into precompiled_header_proposal
…ofx/sconsProject into precompiled_header_proposal
…ofx/sconsProject into precompiled_header_proposal
…ofx/sconsProject into precompiled_header_proposal
…ofx/sconsProject into precompiled_header_proposal
… precompiled_header_proposal

Conflicts:
	__init__.py
* deal with "path too long" issues (disabled until it works)
* qt.py updated solving moc.exe that generates too long include paths
* qt.py updated to deal with translations
…ofx/sconsProject into precompiled_header_proposal
@fabiencastan
Copy link
Member Author

It would be interesting to merge this branch with many interesting things, but I noticed few things to fix.

@edubois Could you fix that?
@mfe Could you check this branch with TuttleOFX on windows ?

@edubois
Copy link
Member

edubois commented Jun 18, 2013

Ok, I am taking your notes in consideration, I will try to fix that as soon
as possible, during the next week.

I am using this branch every weeks without any issues, but concerning the
precompiled headers, there is some work to do to make the code cleaner.

Thank you for your reading.
-Eloi.

2013/6/18 Fabien Castan [email protected]

It would be interesting to merge this branch with many interesting things,
but I noticed few things to fix.

@edubois https://github.com/edubois Could you fix that?
@mfe https://github.com/mfe Could you check this branch with TuttleOFX
on windows ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/5#issuecomment-19641383
.

*Eloi du Bois
*

@fabiencastan
Copy link
Member Author

Thanks !

@mfe
Copy link
Member

mfe commented Jun 19, 2013

Ok, I'll test asap.

@mfe mfe closed this Jun 19, 2013
@mfe mfe reopened this Jun 19, 2013
edubois added 14 commits July 9, 2013 21:28
…ofx/sconsProject into precompiled_header_proposal
* added comments for win32 commands spawn
* added comments for qt.py include simplifier
* Fixed issue with qt5 on MACOSX using framework: library where added with -lQtCore and -framework QtCore
* Fixed issue with qt5 that was making modules dependencies wrongly added
* Fixed issue with poco libraries
…ofx/sconsProject into precompiled_header_proposal
…s useful when cross-compiling (eg. android).

* name of the option: SHLIBSUFFIX
… precompiled_header_proposal

Conflicts:
	__init__.py
@@ -270,6 +293,10 @@ def generate(env):
QT_MOCCXXPREFIX = '',
QT_MOCCXXSUFFIX = '.moc',
QT_UISUFFIX = '.ui',
QT4_LUPDATE = os.path.join('$QT_BINPATH','lupdate'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is common for Qt3, Qt4 and Qt5.
So the name should be QT_LUPDATE instead of QT4_LUPDATE, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe, yes, this needs more tests.

That's something I can try today.

2014-05-09 14:15 GMT+02:00 Fabien Castan [email protected]:

In tools/qt.py:

@@ -270,6 +293,10 @@ def generate(env):
QT_MOCCXXPREFIX = '',
QT_MOCCXXSUFFIX = '.moc',
QT_UISUFFIX = '.ui',

  •            QT4_LUPDATE = os.path.join('$QT_BINPATH','lupdate'),
    

This file is common for Qt4 and Qt5.
So the name should be QT_LUPDATE instead of QT4_LUPDATE, no?


Reply to this email directly or view it on GitHubhttps://github.com//pull/5/files#r12472829
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants