Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : freeze easing objects #617

Merged
merged 6 commits into from
Apr 2, 2023

Conversation

MasatoMakino
Copy link
Contributor

Related Issues

Properties of Easing object can reassignment #610
Add unit test for easing function #608 comment

Purpose of this Pull Request

This PR is to block any reassignment of Easing objects.

Details of the changes

  • Freeze Easing object.
  • Add unit test.

@trusktr trusktr linked an issue Aug 2, 2021 that may be closed by this pull request
@trusktr
Copy link
Member

trusktr commented Apr 2, 2023

mentioned in the issue, lets keep Object.freeze, but restore the same export format so it isn't breaking,

@trusktr trusktr changed the base branch from master to main April 2, 2023 22:26
@trusktr trusktr merged commit 9d64c19 into tweenjs:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Properties of Easing object can reassignment
2 participants