improve component blueprint for octane #213
Conversation
| // add your test properties here | ||
| } | ||
|
|
||
| moduleForComponent('<%= componentPathName %>', '<%= friendlyTestDescription %>', { |
There was a problem hiding this comment.
One thought: while we’re at it, we should, uhh, just get rid of the old-style moduleFor* blueprints. YIKES. I’d forgotten just how out of date our blueprints are. (Doesn’t have to be this PR.)
| // anything which *must* be merged to prototype here | ||
| }) { | ||
| // normal class body definition here | ||
| export default class <%= classifiedModuleName %> extends Component { |
There was a problem hiding this comment.
Let’s delete module unification files as well (again, doesn’t have to be this PR). Module unification is dead, long live template imports. 😅
There was a problem hiding this comment.
Make sure everyone who's using module unification has stopped using it before doing that...
There was a problem hiding this comment.
Or throw an error with a link to a codemod that migrates the old fashioned folk up to an octane layout
There was a problem hiding this comment.
While that’d be a nice thing to do I don’t think we need to do it. When we do it, we will cut a major release and note that we’ve dropped support for MU. Ember itself stopped supporting it in the blueprints long since, I believe, and we don’t want to support generating more code that way from our POV. We already dropped support for it in a variety of places in the core addon.
|
@BryanCrotaz I will merge this "as is" as soon as you fix the linting issues here! |
|
Note, you may also end up wanting to rebase as I land a handful of updates to the repo today! |
BREAKING CHANGE: drops all support for pre-[RFC 0232][rfc] blueprints, since these have long since been replaced. Note that this commit also removes the component blueprints entirely, in favor of landing updated versions of them in [another PR][pr]. [rfc]: https://emberjs.github.io/rfcs/0232-simplify-qunit-testing-api.html [pr]: #213
BREAKING CHANGE: drops all support for pre-[RFC 0232][rfc] blueprints, since these have long since been replaced. Note that this commit also removes the component blueprints entirely, in favor of landing updated versions of them in [another PR][pr]. [rfc]: https://emberjs.github.io/rfcs/0232-simplify-qunit-testing-api.html [pr]: #213
remove comment Co-authored-by: Chris Krycho <[email protected]>
|
It appears that no commits were made to master, so no rebase needed? |
|
closed in favour of #218 |
Bring up to date with ember blueprints and strongly type
thisin testsBring templates into components folder too