-
-
Notifications
You must be signed in to change notification settings - Fork 531
5.0: Update django.contrib.gis.db.backends.postgis.operations
#2138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sobolevn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just like in as_sql:
| template_params: Mapping[str, Any], |
check_geometry: https://github.com/django/django/blob/d59066b90c2ef91a956c6682ed3d25bbb31bf216/django/contrib/gis/db/backends/postgis/operations.py#L42
But! as_sql also calls check_raster which uses mutation :(
https://github.com/django/django/blob/d59066b90c2ef91a956c6682ed3d25bbb31bf216/django/contrib/gis/db/backends/postgis/operations.py#L59-L62
So, template_params is at least MutableMapping
sobolevn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I misclicked. This needs to be changed
I appreciate your thorough explanation! Thanks to your guidance, I now have a clear understanding. I've revised the section accordingly and have uploaded the updates. Thank you for your assistance! |
sobolevn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, also update .as_sql method from the base class
Thank you for your guidance in revising it! :) |
sobolevn
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I have made things!
Update stubs for
django.contrib.gis.db.backends.postgis.operationsfor Django 5.0.django.contrib.gis.db.backends.postgis.operationsdjango.contrib.gis.db.backends.postgis.operations.PostGISOperator.check_geographywas addedRelated issues
Refs
Upstream PR