Add realTimeZonedDateTime to Clock JVM extensions
#4316
Merged
+7
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djspiewak
previously approved these changes
Mar 24, 2025
There was a problem hiding this comment.
I like this quite a lot, but reading the diff, I just realized that we split ClockPlatform to JVM + Native, while IOCompanion is only split to JVM. We should make this consistent, though it may take a bit more refactoring. My guess is we want to revisit this after #4201 lands.
Would you mind opening an issue to track this? Then we can merge this PR.
|
Oh yes, good callout. Will create issue to track. |
|
Done #4323 |
armanbilge
reviewed
Mar 25, 2025
kernel/jvm-native/src/main/scala/cats/effect/kernel/ClockPlatform.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Arman Bilge <armanbilge@gmail.com>
armanbilge
changed the title
realTimeZonedDateTime to Clock JVM extensions
armanbilge
reviewed
Mar 26, 2025
kernel/jvm-native/src/main/scala/cats/effect/kernel/ClockPlatform.scala
Outdated
Show resolved
Hide resolved
armanbilge
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add realTimeZonedDateTime to Clock extensions for convenience