Skip to content

Don't bother with a rule merger if rule arguments are the same #1086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JoshuaKGoldberg opened this issue May 23, 2021 · 1 comment · Fixed by #1092
Closed

Don't bother with a rule merger if rule arguments are the same #1086

JoshuaKGoldberg opened this issue May 23, 2021 · 1 comment · Fixed by #1092
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request

Comments

@JoshuaKGoldberg
Copy link
Member

Overview

As noted in #1085: some community rulesets have overlapping rules to others with the same output ESLint rules: e.g. both convertAdjacentOverloadSignatures and convertConsecutiveOverloads outputting @typescript-eslint/adjacent-overload-signatures.

Actual Behavior

A rule merger will be requested the second+ time an ESLint rule is seen in a converter's output: even if it outputs the same rule arguments as the ESLint rule's previously output rule arguments.

Expected Behavior

A rule merger should only be called for if an ESLint's rules are seen a second+ time with new rule arguments.

@JoshuaKGoldberg JoshuaKGoldberg added type: enhancement New feature or request status: accepting prs Please, send in a PR to resolve this! ✨ good first issue Good for newcomers; welcome aboard! labels May 23, 2021
@Res42
Copy link
Contributor

Res42 commented May 23, 2021

I'll do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers; welcome aboard! status: accepting prs Please, send in a PR to resolve this! ✨ type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants