Skip to content

Do not use merger if arguments are the same. #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 26, 2021
Merged

Do not use merger if arguments are the same. #1092

merged 4 commits into from
May 26, 2021

Conversation

Res42
Copy link
Contributor

@Res42 Res42 commented May 23, 2021

PR Checklist

Overview

Do not use merger if arguments are the same.

Also this adds a new feature: creating a merger is not needed if there are no configuration options for the rule.

Removed unneeded mergers (for rules with no configuration options).

@Res42
Do not use merger if arguments are the same.
e0699d4 
Also this adds a new feature: creating a merger is not needed if there are no configuration options for the rule.
Removed unneeded mergers (for rules with no configuration options).
JoshuaKGoldberg
JoshuaKGoldberg requested changes May 23, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core logic looks great -- and greatly appreciated on the thorough tests and merger cleanups! Requesting changes around the docs linking and style.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label May 23, 2021
@Res42
Copy link
Contributor Author

Res42 commented May 24, 2021

Done all change requests. Should I ping now?

@JoshuaKGoldberg JoshuaKGoldberg self-requested a review May 25, 2021 14:10
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels May 25, 2021
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label May 26, 2021
JoshuaKGoldberg
JoshuaKGoldberg approved these changes May 26, 2021
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, thanks so much @Res42!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 6fa6b6f into typescript-eslint:main May 26, 2021
@Res42 Res42 deleted the feature/1086 branch May 26, 2021 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't bother with a rule merger if rule arguments are the same
2 participants
@Res42 @JoshuaKGoldberg