Skip to content

simpleRuleConverter and argument helpers for simple cases #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kbrilla opened this issue Nov 7, 2020 · 2 comments
Closed

simpleRuleConverter and argument helpers for simple cases #813

kbrilla opened this issue Nov 7, 2020 · 2 comments
Assignees
Labels
status: aged away Not enough activity occurred on this issue in a reasonable amount of time to justify taking action. type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans

Comments

@kbrilla
Copy link
Contributor

kbrilla commented Nov 7, 2020

🚀 Feature Request

  1. I think it is tedious to create all the files, tests, etc... for simple rule converters that are basically changing the name, adding plugins and that's it. For such plugins, it would be great to add a simple helper function or even an additional place that we just pass those simple values.

  2. For simple cases of argument mapping we could add a mapping function that would help with that.

Existing Behavior

Even a simple rule takes at least 2 new files and 1 change in the existing one - often copy-pasting code.

Change Proposal

PR in progress

@JoshuaKGoldberg JoshuaKGoldberg added status: accepting prs Please, send in a PR to resolve this! ✨ type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans labels Nov 8, 2020
@JoshuaKGoldberg
Copy link
Member

👋 @criskrzysiu are you still interested in tackling this? No worries if not, I can if you don't have time!

@JoshuaKGoldberg
Copy link
Member

I'm going to close this issue for aging out. Now that we have a utility script to auto-generate those templating files (#1089) I'm not convinced this is worth the effort.

Please post back here if you disagree!

@JoshuaKGoldberg JoshuaKGoldberg added status: aged away Not enough activity occurred on this issue in a reasonable amount of time to justify taking action. and removed status: accepting prs Please, send in a PR to resolve this! ✨ labels Jul 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: aged away Not enough activity occurred on this issue in a reasonable amount of time to justify taking action. type: cleanup Code smells, incorrect tests, build systems, or other internal shenanigans
Projects
None yet
Development

No branches or pull requests

2 participants