Added quick utility script for making a new rule #1089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
added
the
status: waiting for reviewer
JoshuaKGoldberg
commented
May 23, 2021
|
I generated my rules too, so here are some thoughts.
...(tslintRule.ruleArguments.length !== 0 && {
ruleArguments: tslintRule.ruleArguments,
}),
|
Res42
reviewed
May 23, 2021
Enforces that exports and imports are sorted alphabetically, with a fixer for ESLint's `--fix`. Precursor to #1089 to make it easier to insert lines into `ruleConverters.ts` automatically.
2 tasks
added 2 commits
May 28, 2021 01:10
JoshuaKGoldberg
added
status: waiting for author
JoshuaKGoldberg
pushed a commit
that referenced
this pull request
May 28, 2021
* Enabled eslint-plugin-simple-import-sort internally * Added eslint-plugin-simple-import-sort Enforces that exports and imports are sorted alphabetically, with a fixer for ESLint's `--fix`. Precursor to #1089 to make it easier to insert lines into `ruleConverters.ts` automatically. * Reset package-lock.json * Autofix imports
JoshuaKGoldberg
removed
the
status: waiting for author
KingDarBoja
approved these changes
May 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Res42's efforts in #1085 reminded me I've been meaning to write this for a little while... should be helpful in setting up new rules, in lieu of #813. Thoughts?