Enabled eslint-plugin-simple-import-sort internally #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforces that exports and imports are sorted alphabetically, with a fixer for ESLint's `--fix`. Precursor to #1089 to make it easier to insert lines into `ruleConverters.ts` automatically.
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
added
the
status: waiting for reviewer
|
Everything looks great, although I didn't spot the husky / ci fixes unless those were related to the lock file, right? |
KingDarBoja
approved these changes
May 28, 2021
|
Yeah I'll tackle those next - figured this'd be a good first step. 👍 |
JoshuaKGoldberg
added
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Enforces that exports and imports are sorted alphabetically, with a fixer for ESLint's
--fix.Precursor to #1089 to make it easier to insert lines into
ruleConverters.tsautomatically.Includes some Prettier fixes (#1100, #1101)...