Fix @typescript-eslint disable rules. #1093
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKGoldberg
added
the
status: waiting for reviewer
KingDarBoja
reviewed
May 26, 2021
Comment on lines
+32
to
+35
| { | ||
| ruleName: "indent", | ||
| ruleSeverity: "off", | ||
| }, |
There was a problem hiding this comment.
Based on #149, I think it is safe to update the Typescript ESLint Roadmap with this conversion. @JoshuaKGoldberg
KingDarBoja
approved these changes
May 26, 2021
JoshuaKGoldberg
requested changes
May 27, 2021
JoshuaKGoldberg
added
status: waiting for author
JoshuaKGoldberg
removed
the
status: waiting for author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Fix converters for
@typescript-eslintrules where the rule needs the baseESLintrule to be disabled.Also added a sanity check test which naively searches for these rule pairs and fails if the base rule is not disabled.