Skip to content

feat: converters for ngrx rules #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Aug 30, 2021
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/converters/lintConfigs/rules/ruleConverters.ts
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,17 @@ import { convertCurly } from "./ruleConverters/curly";
import { convertCyclomaticComplexity } from "./ruleConverters/cyclomatic-complexity";
import { convertDeprecation } from "./ruleConverters/deprecation";
import { convertEofline } from "./ruleConverters/eofline";
import { convertActionHygiene } from "./ruleConverters/eslint-plugin-ngrx/action-hygiene";
import { convertAvoidDispatchingMultipleActionsSequentially } from "./ruleConverters/eslint-plugin-ngrx/avoid-dispatching-multiple-actions-sequentially";
import { convertEffectCreatorAndDecorator } from "./ruleConverters/eslint-plugin-ngrx/effect-creator-and-decorator";
import { convertNoDispatchInEffects } from "./ruleConverters/eslint-plugin-ngrx/no-dispatch-in-effects";
import { convertNoEffectDecorator } from "./ruleConverters/eslint-plugin-ngrx/no-effect-decorator";
import { convertNoEffectsInProviders } from "./ruleConverters/eslint-plugin-ngrx/no-effects-in-providers";
import { convertNoMultipleActionsInEffects } from "./ruleConverters/eslint-plugin-ngrx/no-multiple-actions-in-effects";
import { convertNoReducerInKeyNames } from "./ruleConverters/eslint-plugin-ngrx/no-reducer-in-key-names";
import { convertNoTypedStore } from "./ruleConverters/eslint-plugin-ngrx/no-typed-store";
import { convertOnReducerExplicitReturnType } from "./ruleConverters/eslint-plugin-ngrx/on-reducer-explicit-return-type";
import { convertSelectorForSelect } from "./ruleConverters/eslint-plugin-ngrx/selector-for-select";
import { convertJsxBanProps } from "./ruleConverters/eslint-plugin-react/jsx-ban-props";
import { convertJsxBooleanValue } from "./ruleConverters/eslint-plugin-react/jsx-boolean-value";
import { convertJsxCurlySpacing } from "./ruleConverters/eslint-plugin-react/jsx-curly-spacing";
Expand Down Expand Up @@ -351,6 +362,21 @@ export const ruleConverters = new Map([
["new-parens", convertNewParens],
["newline-before-return", convertNewlineBeforeReturn],
["newline-per-chained-call", convertNewlinePerChainedCall],
["ngrx-action-hygiene", convertActionHygiene],
[
"ngrx-avoid-dispatching-multiple-actions-sequentially",
convertAvoidDispatchingMultipleActionsSequentially,
],
["ngrx-effect-creator-and-decorator", convertEffectCreatorAndDecorator],
["ngrx-no-dispatch-in-effects", convertNoDispatchInEffects],
["ngrx-no-effect-decorator", convertNoEffectDecorator],
["ngrx-no-effects-in-providers", convertNoEffectsInProviders],
["ngrx-no-multiple-actions-in-effects", convertNoMultipleActionsInEffects],
["ngrx-no-reducer-in-key-names", convertNoReducerInKeyNames],
["ngrx-no-reducer-in-key-names", convertNoReducerInKeyNames],
["ngrx-no-typed-store", convertNoTypedStore],
["ngrx-on-reducer-explicit-return-type", convertOnReducerExplicitReturnType],
["ngrx-selector-for-select", convertSelectorForSelect],
["no-all-duplicated-branches", convertNoAllDuplicatedBranches],
["no-alphabetical-sort", convertNoAlphabeticalSort],
["no-angle-bracket-type-assertion", convertNoAngleBracketTypeAssertion],
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertActionHygiene: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/good-action-hygiene",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertAvoidDispatchingMultipleActionsSequentially: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/avoid-dispatching-multiple-actions-sequentially",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertEffectCreatorAndDecorator: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/effect-decorator-and-creator",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertNoDispatchInEffects: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/no-dispatch-in-effects",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertNoEffectDecorator: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/no-effect-decorator",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertNoEffectsInProviders: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/no-effects-in-providers",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertNoMultipleActionsInEffects: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/no-multiple-actions-in-effects",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertNoMultipleStores: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/no-multiple-global-stores",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertNoReducerInKeyNames: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/no-reducer-in-key-names",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertNoTypedStore: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/no-typed-global-store",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertOnReducerExplicitReturnType: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/on-function-explicit-return-type",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
import { RuleConverter } from "../../ruleConverter";

export const convertSelectorForSelect: RuleConverter = () => {
return {
rules: [
{
ruleName: "ngrx/use-selector-in-select",
},
],
plugins: ["eslint-plugin-ngrx"],
};
};
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertActionHygiene } from "../action-hygiene";

describe(convertActionHygiene, () => {
test("conversion without arguments", () => {
const result = convertActionHygiene({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/good-action-hygiene",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertAvoidDispatchingMultipleActionsSequentially } from "../avoid-dispatching-multiple-actions-sequentially";

describe(convertAvoidDispatchingMultipleActionsSequentially, () => {
test("conversion without arguments", () => {
const result = convertAvoidDispatchingMultipleActionsSequentially({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/avoid-dispatching-multiple-actions-sequentially",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertEffectCreatorAndDecorator } from "../effect-creator-and-decorator";

describe(convertEffectCreatorAndDecorator, () => {
test("conversion without arguments", () => {
const result = convertEffectCreatorAndDecorator({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/effect-decorator-and-creator",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertNoDispatchInEffects } from "../no-dispatch-in-effects";

describe(convertNoDispatchInEffects, () => {
test("conversion without arguments", () => {
const result = convertNoDispatchInEffects({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/no-dispatch-in-effects",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertNoEffectDecorator } from "../no-effect-decorator";

describe(convertNoEffectDecorator, () => {
test("conversion without arguments", () => {
const result = convertNoEffectDecorator({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/no-effect-decorator",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertNoEffectsInProviders } from "../no-effects-in-providers";

describe(convertNoEffectsInProviders, () => {
test("conversion without arguments", () => {
const result = convertNoEffectsInProviders({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/no-effects-in-providers",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertNoMultipleActionsInEffects } from "../no-multiple-actions-in-effects";

describe(convertNoMultipleActionsInEffects, () => {
test("conversion without arguments", () => {
const result = convertNoMultipleActionsInEffects({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/no-multiple-actions-in-effects",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertNoMultipleStores } from "../no-multiple-stores";

describe(convertNoMultipleStores, () => {
test("conversion without arguments", () => {
const result = convertNoMultipleStores({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/no-multiple-global-stores",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertNoReducerInKeyNames } from "../no-reducer-in-key-names";

describe(convertNoReducerInKeyNames, () => {
test("conversion without arguments", () => {
const result = convertNoReducerInKeyNames({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/no-reducer-in-key-names",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import { convertNoTypedStore } from "../no-typed-store";

describe(convertNoTypedStore, () => {
test("conversion without arguments", () => {
const result = convertNoTypedStore({
ruleArguments: [],
});

expect(result).toEqual({
rules: [
{
ruleName: "ngrx/no-typed-global-store",
},
],
plugins: ["eslint-plugin-ngrx"],
});
});
});
Loading