Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue171 short circuiting assignment operators translation #205

Conversation

chorom-ham
Copy link
Contributor

PR전에 아래의 사항들을 확인하셨나요? 확인하셨다면, 체크해주세요!

  • [V] CONTRIBUTING.md 파일을 정독했습니다.
  • [V] lint 검사를 진행했습니다.
  • [V] fetch를 통해 최신 upstream 내용을 반영했습니다.
👆 꼭 확인해주시길 바랍니다! 👆
  • PR의 종류가 무엇인지 체크해주세요!
    • Bug
    • [V] Docs
    • Typo
    • etc.

PR에 대한 간단한 내용 설명을 부탁드립니다!
TypeScript 4.0 번역(이슈 #171 ) 중 Short-Circuiting Assignment Operators 부분을 번역했습니다
*

Copy link
Contributor

@yeonjuan yeonjuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chorom-ham 고생하셨습니다 :)

@chorom-ham
Copy link
Contributor Author

말씀하신대로 수정한 커밋 올렸습니다~! 리뷰 감사합니다 👍

Copy link
Member

@bumkeyy bumkeyy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. 😄

@bumkeyy bumkeyy merged commit 9612a31 into typescript-kr:master Nov 8, 2020
@bumkeyy
Copy link
Member

bumkeyy commented Nov 8, 2020

@all-contributors please add @chorom-ham for translation

@allcontributors
Copy link
Contributor

@bumkeyy

I've put up a pull request to add @chorom-ham! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants