Skip to content

Conversation

@SillyFreak
Copy link
Collaborator

@SillyFreak SillyFreak commented Feb 18, 2025

I'm not sure if this should be merged, would be interested in others' opinions.

I think it's in general useful to have support for testing on prereleases (conditioned on both a Typst and compatible Tytanic prerelease already existing of course). However, the binstall action we use doesn't support prereleases:

Error: install-action v2 does not support semver pre-release and build-metadata: '0.2.0-rc1'; if you need these supports again, please submit an issue at https://github.com/taiki-e/install-action

So this requires extra measures to use cargo install instead. Also, since a prerelease is not the real thing yet, should the template explicitly use them? And if not, is the infrastructure for prereleases still "appropriate" to include?

Basically the options I see are

  • don't merge this
  • remove 0.13.0-rc1 from the matrix, but prepare the action for installing Tytanic prereleases
  • merge as-is, i.e. referencing the Typst and Tytanic prereleases (they would be replaced with the releases once they're out)

I lean towards this being useful enough for package authors to merge in one of the two ways, but would like others' take on this.

@SillyFreak SillyFreak changed the title add testing for Typst 0.13 prerelease (along with general support for testing on prereleases) add support for testing on prereleases Feb 20, 2025
@SillyFreak SillyFreak marked this pull request as draft February 20, 2025 08:45
@SillyFreak
Copy link
Collaborator Author

(since 0.13 and Tytanic 0.2 are out, this becomes a lot less urgent and should probably wait for taiki-e/install-action#858)

@SillyFreak SillyFreak force-pushed the prerelease-testing branch 3 times, most recently from 5694cbb to 46347c5 Compare February 23, 2025 20:01
@SillyFreak
Copy link
Collaborator Author

Thanks to taiki-e/install-action#868, this is now supported without change!

@SillyFreak SillyFreak closed this Feb 23, 2025
@SillyFreak SillyFreak deleted the prerelease-testing branch February 25, 2025 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant