This repository has been archived by the owner on May 3, 2022. It is now read-only.
WIP: Allow developers to opt out of guards. #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People have complained about the one dependency guard. I've added an escape clause where the user of tchannel can globally declare that they know what they are doing.
Raynos
force-pushed
the
unsupported-mode
branch
from
b74c74f to
f196ae9
Compare
| @@ -24,11 +24,14 @@ var assert = require('assert'); | |||
| var process = require('process'); | |||
| var version = require('./package.json').version; | |||
|
|
|||
| var tainted = global.TCHANNEL_UNSUPPORTED_MODE === | |||
There was a problem hiding this comment.
ALL_THE_TCHANNELS="I solemnly swear that I am up to no good"
There was a problem hiding this comment.
TCHANNEL_WARRANTY="void"
There was a problem hiding this comment.
TCHANNEL_MISCHIEF="managed"
Raynos
changed the title
|
RIP |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People have complained about the one dependency guard.
I've added an escape clause where the user of tchannel can
globally declare that they know what they are doing.
cc #259
r: @kriskowal @jcorbin @lxe