-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RPi4 (w/ optional "blower" case) and other component changes. #7
base: master
Are you sure you want to change the base?
Conversation
Add usb-c. Remodel of microhdmi. Update microusb, miniusb with new rear cover to match port profile.
Add and update various gifs for minor USB/microHDMI appearance differences.
Tweaked side vents, still needs better integration with case.scad
Hey, nice work. You even took photos and updated the README, awesome :)
Alright so, These changes are nice, but one thing that would be welcome would be to split the commit atomically. Right now, it's very hard for me to follow how the changes are tied, it makes the review painful, and it will be problematic for potential fixes/blame/revert in the future. Typically, I'd have individual introduction of new electronic component in dedicated commits. Prototype/behavior changes in their dedicated commits as well. The introduction of the board in one as well. And finally the case(s). On the other hand, your "fixup" commits should be included in the appropriate commits. It would really help me reviewing the changes. If you need help with
AFAICT, that blower is very similar to the button pushers thing used for example in the BBB. It's something that has to be printed separately by the user. Look for that button pushers code in These button pushers are built automatically according to button components present on the board. A dedicated |
I Forgot to reply this:
So yeah you are correct: I don't like dependencies. OTOH, it is debatable that people wanting to contribute to shimonbox would have to design every single component. My position would be: all or nothing. If you can have all the components we have defined in shimonbox available upstream in I see a few issues though, the main one being that in shimonbox components have an extra information for the "digging". I'm not sure if this would fit in another project. Also, the dependency for something as core as the component means that if we can't get a component upstream, or if that dependency dies-off, decide to change stuff, it's problematic for us. Any change in a component there could also affect the layout of our boards. In the end, we would probably end up with components split inconsistently between the two projects, and I'm not sure that would be an improvement. I'd rather have a smaller database, with ugly component sketchups, thank risking badly printed cases for our users. |
Here are my changes for adding the board model and case for the Raspberry Pi 4 which include:
There's still some issues I had with implementing my blower case with duct, which I'm not too satisfied with. I'm still willing to fix them up so it integrates better with the main scripts, but was hoping to maybe get some input from you @ubitux on best way to handle.
case.scad
somehow.a) Automated export doesn't create an stl automatically for the duct, and requires user to manually export it by uncommenting lines.
b) The demo gif just shows the duct in fixed position fixed relative to the PCB, and the case top passes through the duct as it lowers. Really the duct should be lowered from above after the case-top.
So yeah, I think my changes could still use some work, but was hoping to hear some thoughts from you before I go changing even more of the main functionality!
And I understand if you are busy and occupied by other things, so take your time. :)