Fix deadlock in the DMA read pipeline #363
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
write_issue_q
dequeue is not valid, the random.bits
may still indicate it is an acc address or may have its garbage bit set. This will erroneously cause the read pipeline output ready to go low, which combinationally causes the SRAM read response interface to deassert ready. As a result, there is a cycle of stalling reading from the SRAMs; however, writeData.valid does not accommodate this stall as it expects a continuous stream of data. This leads to the write queues with one extra data element not dequeued properly every once in a while, which fills up over time and leads to a deadlock. The fix gates the random bits with thewrite_issue_q
output valid.