-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add mkdirs option to Writer#toFile #68
base: master
Are you sure you want to change the base?
Conversation
Why is this not merged? I don't see any issues with the PR, or anything blocking it. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 30 days if no further activity occurs, but feel free to re-open a closed issue if needed. |
Thank you to @isXander for this contribution!
I've forked Konf since it has become unfortunately unmaintained. I've applied your pull request to my fork. Hopefully you can finally use this feature! |
hi, @nhubbard Additionally, I'd recommend against the name "konfig", as npryce/konfig already exists, which uses that name. |
I'm looking to keep it at least at version parity with current Kotlin and Gradle builds. Most of my work on this was purely because I love using Konf and think it's a shame for it to languish. Ideally, if I had unlimited time, I would keep all of the features from the previous build system and rewrite the tests from Spek to either Kotest or pure JUnit5, mostly due to the complete lack of development and the extremely slow execution speed of Spek 1.x. Maybe I would also do some refactoring, like moving back to the modular structure that I had to ditch because of build system constraints when moving to Gradle 8. Thanks for the note on the name, I'll look into that tomorrow. |
Also, I have already integrated #48 into my fork, but it doesn't have any tests as of yet. I've added a reference to it into the README file in my most recent commit. I've also renamed the project back to Konf to prevent conflicting with the other repository and bumped the version to 2.0 to make the difference between the original and my fork more clear. |
I've prepared most of the publishing setup and fixed the name. I have my namespace verified on Maven Central, but something is going on with a JIRA migration for Sonatype, which is making it impossible for me to publish artifacts. I've submitted a support ticket to Sonatype to try and fix it. @solonovamax Feel free to fork my fork and start contributing. I'll review any changes you send in as I see them. Thanks! |
uuhhhh.... unsure about the decision to merge it.... iirc it wasn't at all finished? |
also, for build stuff, I'm willing to completely revamp the build. I have a lot of experience battling with gradle to get it to do what I want. |
do you have a matrix acc, so we could communicate somewhere that isn't issue comments? |
|
No description provided.