Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the background of the menu to a static image #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

josephtclegg
Copy link
Contributor

@josephtclegg josephtclegg commented Oct 31, 2018

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Changed the trianglify background to be a static image.

Approach

Changed the triangleView view component in the MenuViewController class to be a UIView, and simply added a background image to this UIView.

Learning

Researched on stack overflow about adding images to UIViews. Here is a link the the helpful stack overflow answer: https://stackoverflow.com/a/26311986/4694958

Screenshot(s)

image

Checklist

  • My branch follows the branch naming scheme of UCLA Radio, and can merge into master without error.
  • My code follows the code style of this project, and I have linted it to confirm this.
  • I have added tests that prove my fix is effective or that my feature works.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • All new and existing tests passed.

Further Comments

I kept the name of the triangleView component the same, so any references to it ought to stay the same, furthermore since the TrianglifyView class inherited from UIView, the new use of UIView as the type of triangleView ought to allow for all the same functionality of the original TrianglifyView except for the actual use of the Trianglify API, which we do not seem to be using anymore.

@haejinjo haejinjo self-assigned this Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants