Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stream on https instead of port 8000. #39

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

comran
Copy link

@comran comran commented Nov 15, 2018

Allows the stream to be accessible on UCLA_WEB/UCLA_WEB_RES.

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Refactor (change which changes the codebase without affecting its external behavior)
  • Non-breaking change (fix or feature that would causes existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

Allow the stream to work on UCLA_WEB.

Approach

Use HTTPS instead of an arbitrary port that is firewalled by UCLA's network.

Learning

Used NGINX for reverse proxying the stream on the website's backend.

Screenshot(s)

Checklist

  • My branch follows the branch naming scheme of UCLA Radio, and can merge into master without error.
  • My code follows the code style of this project, and I have linted it to confirm this.
  • I have added tests that prove my fix is effective or that my feature works.
  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • All new and existing tests passed.

Platform

Operating System:

Further Comments

Allows the stream to be accessible on UCLA_WEB/UCLA_WEB_RES.
@comran comran requested a review from tanzeelak as a code owner November 15, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant