Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP 83 MessageType Vocab #306

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

CP 83 MessageType Vocab #306

wants to merge 4 commits into from

Conversation

kchason
Copy link
Contributor

@kchason kchason commented Sep 13, 2021

Addresses OC-90 and the related CP-83

@ajnelson-nist ajnelson-nist self-requested a review September 13, 2021 15:17
@ajnelson-nist
Copy link
Contributor

Whoops, this also needs to be filed against develop, not master. Can you please adjust the PR, or close and re-file if you can't?

@kchason kchason changed the base branch from master to develop September 13, 2021 15:20
@kchason
Copy link
Contributor Author

kchason commented Sep 13, 2021

Switched to "develop" branch.

@ajnelson-nist
Copy link
Contributor

Hrm. Looks like that was a non-trivial pull request move because of the state of develop. You might be better off not fighting Git and re-doing those commits starting from the current state of develop. Feel free to force-push to your branch. This patch series should ideally have just one or two commits, and not record a jaunt from the master branch.

Separately, I see the pyshacl issue, which was resolved in upstream issue 93 a few hours ago. (That is a residual of the use_2to3 / rdflib-jsonld situation from last week.) But apparently CI isn't picking up the new release. Let's see if CI fails again on pyshacl after your rework.

@kchason
Copy link
Contributor Author

kchason commented Oct 13, 2021

@ajnelson-nist this should be all resolved now and updated from develop. If you'd prefer I squash the merge commits, I can certainly do that too.

@kchason kchason changed the title Feature CP 83 CP 83 MessageType Vocab Dec 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajnelson-nist ajnelson-nist Awaiting requested review from ajnelson-nist

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kchason @ajnelson-nist @sbarnum