Incorporate MICM into build and start chem process structure #114
Conversation
| @@ -1,6 +1,6 @@ | |||
| cmake_minimum_required(VERSION 3.5) | |||
|
|
|||
| project(CATChem VERSION 0.1.0 LANGUAGES Fortran) | |||
| project(CATChem VERSION 0.1.0 LANGUAGES Fortran C CXX) | |||
There was a problem hiding this comment.
Just nothing that, without adding these, was getting this error:
CMake Error in src/process/chem/CMakeLists.txt:
No known features for CXX compiler
""
version .
There was a problem hiding this comment.
Also note, it seems like really it's only necessary to add CXX to get a successful build
There was a problem hiding this comment.
@K20shores do you know if there's a way to get MUSICA to build without changing this, by specifying something elsewhere instead? Just curious, as our project code is all Fortran really.
There was a problem hiding this comment.
@zmoon I think this is required. If not, I don't think the linker will be properly configured. I could be wrong though
There was a problem hiding this comment.
Thanks @K20shores , that's good to hear.
There was a problem hiding this comment.
Ah, if you want to only enable these languages only when musica is built, somewhere you can do something like this
if (ENABLE_MUSICA)
enable_language(C)
enable_language(CXX)
endif()
|
@mbruckner-work Please take a look |
|
Very cool! Let's talk about this in our UFS-Chem meetings on Monday. I have a couple of questions, but this looks great! |
| set(_srcs CCPr_Chem_Mod.F90) | ||
|
|
||
| add_library(${_lib} ${_srcs}) |
There was a problem hiding this comment.
The only cmake related comment I can think of is that it's recommended to use target_sources in newer versions of cmake. I think if you use target_sources and generate a project for something like Xcode or Visual Studio, this helps Cmake create better integration with that IDE. This certainly isn't a requirement though
There was a problem hiding this comment.
Thanks @K20shores , I can update the whole project to use that in a separate PR.
cc: @mattldawson