forked from NCAR/ccpp-physics
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sixth reconciliation PR from production/RRFS.v1 #235
Merged
rhaesung
merged 11 commits into
ufs-community:ufs/dev
from
grantfirl:rrfsv1-to-ufs/dev6
Feb 12, 2025
Merged
Sixth reconciliation PR from production/RRFS.v1 #235
rhaesung
merged 11 commits into
ufs-community:ufs/dev
from
grantfirl:rrfsv1-to-ufs/dev6
Feb 12, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2024
dustinswales
approved these changes
Dec 5, 2024
climbfuji
approved these changes
Dec 5, 2024
Qingfu-Liu
approved these changes
Dec 9, 2024
rhaesung
approved these changes
Dec 11, 2024
@grantfirl would it be ok to combine in #247 to this pr? no baseline change |
Yes, that is fine. I'll do this. |
all tests are done at ufs-community/ufs-weather-model#2529 @rhaesung @grantfirl @dustinswales can you go ahead to merge this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical to #198
This is @dustinswales work.
This PR adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions.
#247 is combined into this PR:
Fixes this problem:
It was caused by missing values (-1e+20) for sea surface temperature on
wet
points in input data. (Wet
points are points where the CCPPwet
array is true, thus indicating the surface is at least partly water.) There's a bug fix and a workaround:wet
array can be mistakenly true when it should be false due to the location being 100% ice. An "else" statement corrects this.wet
point, the lowest model level temperature is used instead.There is no other temperature available on those points that can reasonably be used as a sea surface temperature. The lowest model level temperature may not be a perfect analogue for the sea surface temperature, but it'll be more realistic than -1E+20 K.