Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sixth reconciliation PR from production/RRFS.v1 #235

Merged
merged 11 commits into from
Feb 12, 2025

Conversation

grantfirl
Copy link
Collaborator

@grantfirl grantfirl commented Dec 5, 2024

Identical to #198

This is @dustinswales work.

This PR adds a new diagnostic, instantaneous downward shortwave flux at the surface assuming clear-sky conditions.

#247 is combined into this PR:

Fixes this problem:

It was caused by missing values (-1e+20) for sea surface temperature on wet points in input data. (Wet points are points where the CCPP wet array is true, thus indicating the surface is at least partly water.) There's a bug fix and a workaround:

  1. Bug fix: In certain situations, the wet array can be mistakenly true when it should be false due to the location being 100% ice. An "else" statement corrects this.
  2. Workaround: If the input sea surface temperatures (tsfco) are invalid on a wet point, the lowest model level temperature is used instead.

There is no other temperature available on those points that can reasonably be used as a sea surface temperature. The lowest model level temperature may not be a perfect analogue for the sea surface temperature, but it'll be more realistic than -1E+20 K.

@jkbk2004
Copy link

@grantfirl would it be ok to combine in #247 to this pr? no baseline change

@grantfirl
Copy link
Collaborator Author

@grantfirl would it be ok to combine in #247 to this pr? no baseline change

Yes, that is fine. I'll do this.

@jkbk2004
Copy link

all tests are done at ufs-community/ufs-weather-model#2529 @rhaesung @grantfirl @dustinswales can you go ahead to merge this pr?

@rhaesung rhaesung merged commit 1d0bcdc into ufs-community:ufs/dev Feb 12, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants