Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tempo Implementation #250

Open
wants to merge 10 commits into
base: ufs/dev
Choose a base branch
from

Conversation

AndersJensen-NOAA
Copy link
Collaborator

This PR replaces #245

@grantfirl
Copy link
Collaborator

grantfirl commented Feb 7, 2025

@AndersJensen-NOAA Is this the final PR? It makes it very difficult to review this when new PRs replace old ones. For example, in order to see what comments were addressed from #245, I have to go back and forth between that one and this one and check for changes manually. If you had just made your changes in #245, it would have been much easier to continue reviewing this because GitHub highlights changes for you.

@AndersJensen-NOAA
Copy link
Collaborator Author

@AndersJensen-NOAA Is this the final PR? It makes it very difficult to review this when new PRs replace old ones. For example, in order to see what comments were addressed from #245, I have to go back and forth between that one and this one and check for changes manually. If you had just made your changes in #245, it would have been much easier to continue reviewing this because GitHub highlights changes for you.

@grantfirl Yes, this is the final PR. Apologies for the continued replacement PRs. The issue mentioned in this discussion
NOAA-EMC/fv3atm#923
tripped me up for so long (several days) that I decided to start over and rebuild the PR in one sitting, piece by piece to track it down.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants