Tenth reconciliation PR from production/RRFS.v1 #252
+20
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[production/RRFS.v1] Thompson-Eidhammer microphysics code formatting
[production/RRFS.v1] Update MYNN PBL & Smoke for RRFS.v1
…ctives (NOT operational!)
[production/RRFS.v1] Fix improperly assigned fire emissions for ebb_dcycle==1 for retrospectives (NOT operational!)
…clrskyflx_diag [production/RRFS.v1] Add clear-sky shortwave downward at surface flux to available diagnostics.
[production/RRFS.v1] update deep soil temperature of RUC LSM
The final physics update PR to RRFS.v1
[production/RRFS.v1] add a new parameter to control if G-F cold starts or not
grantfirl
requested review from
lisa-bengtsson,
rhaesung,
Qingfu-Liu,
dustinswales and
JongilHan66
as code owners
JongilHan66
approved these changes
Feb 7, 2025
Qingfu-Liu
approved these changes
Feb 7, 2025
This was referenced Feb 10, 2025
rhaesung
approved these changes
Feb 10, 2025
rhaesung
reviewed
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This work is from @JiliDong-NOAA and is identical to PR #225. The description for that PR is pasted below:
This PR follows Jongil's suggestion and aims to reduce the large convective reflectivity caused by saSAS adjustment in the first timestep during a warm start. The issue is likely related to the inconsistency when DA updates the moisture at t but not the moisture from the previous timestep (t-36s). The moisture from the previous timestep is needed for initializing sigmab (updraft area fraction) when calculating qadv (q advection or tendency term).
The PR forces qadv to zero in the first timestep when a namelist parameter sigmab_coldstart is set to .true. It also reduces the lower limit of sigmab from 0.01 to 0.0 in the first timestep.
sigmab_modification.pptx