Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FV3 CCPP: wet() bug fix and workaround for bad tsfco #2572

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

SamuelTrahanNOAA
Copy link
Collaborator

@SamuelTrahanNOAA SamuelTrahanNOAA commented Jan 27, 2025

Commit Queue Requirements:

  • Fill out all sections of this template.
  • All sub component pull requests have been reviewed by their code managers. There are no reviews yet.
  • Run the full Intel+GNU RT suite (compared to current baselines) on either Hera/Derecho/Hercules
  • Commit 'test_changes.list' from previous step

Description:

Fixes this problem:

It was caused by missing values (-1e+20) for sea surface temperature on wet points in input data. (Wet points are points where the CCPP wet array is true, thus indicating the surface is at least partly water.) There's a bug fix and a workaround:

  1. Bug fix: In certain situations, the wet array can be mistakenly true when it should be false due to the location being 100% ice. An "else" statement corrects this.
  2. Workaround: If the input sea surface temperatures (tsfco) are invalid on a wet point, the lowest model level temperature is used instead.

There is no other temperature available on those points that can reasonably be used as a sea surface temperature. The lowest model level temperature may not be a perfect analogue for the sea surface temperature, but it'll be more realistic than -1E+20 K.

Commit Message:

 * ccpp-physics - wet() bug fix and workaround for bad tsfco

Priority:

  • Normal

Git Tracking

UFSWM:

Sub component Pull Requests:

UFSWM Blocking Dependencies:

  • None

Changes

Regression Test Changes (Please commit test_changes.list):

  • No Baseline Changes.

Input data Changes:

  • None.

Library Changes/Upgrades:

  • No Updates

Testing Log:

  • RDHPCS
    • Hera
    • Orion
    • Hercules
    • Jet
    • GaeaC5
    • GaeaC6
    • Derecho
  • WCOSS2
    • Dogwood/Cactus
    • Acorn
  • CI
  • opnReqTest (complete task if unnecessary)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

global_nest_v1 suite: infinite cumulative surface upwelling long-wave flux
1 participant